fix: resolve stale tests and broken links from analyst walkthrough - #121
Merged
Conversation
added 2 commits
April 7, 2026 17:51
…ough - README: remove _v1/_v2 suffixes from evaluation guide file references - Markdownlint: fix MD058/MD037/MD003 in 2 MATPOWER research files - Tests: update 36 stale test expectations across 6 test files to match current page structure (### headings vs <details> cards, Strong/Adequate/ Weak/Failing tiers vs letter grades, updated risk register count, current page content patterns) - Full test suite: 270 passed, 0 failed
Take main's restructured README which already includes proper hyperlinks to evaluation guide files (our branch's fix was removing stale _v1/_v2 suffixes; main's rewrite replaced the entire section with linked refs).
joeshull
added a commit
that referenced
this pull request
Apr 8, 2026
…ough (#121) - README: remove _v1/_v2 suffixes from evaluation guide file references - Markdownlint: fix MD058/MD037/MD003 in 2 MATPOWER research files - Tests: update 36 stale test expectations across 6 test files to match current page structure (### headings vs <details> cards, Strong/Adequate/ Weak/Failing tiers vs letter grades, updated risk register count, current page content patterns) - Full test suite: 270 passed, 0 failed Co-authored-by: Joe <joe@zerocapital.com>
joeshull
added a commit
that referenced
this pull request
Apr 8, 2026
…ough (#121) - README: remove _v1/_v2 suffixes from evaluation guide file references - Markdownlint: fix MD058/MD037/MD003 in 2 MATPOWER research files - Tests: update 36 stale test expectations across 6 test files to match current page structure (### headings vs <details> cards, Strong/Adequate/ Weak/Failing tiers vs letter grades, updated risk register count, current page content patterns) - Full test suite: 270 passed, 0 failed Co-authored-by: Joe <joe@zerocapital.com>
joeshull
added a commit
that referenced
this pull request
Apr 8, 2026
…ough (#121) - README: remove _v1/_v2 suffixes from evaluation guide file references - Markdownlint: fix MD058/MD037/MD003 in 2 MATPOWER research files - Tests: update 36 stale test expectations across 6 test files to match current page structure (### headings vs <details> cards, Strong/Adequate/ Weak/Failing tiers vs letter grades, updated risk register count, current page content patterns) - Full test suite: 270 passed, 0 failed Co-authored-by: Joe <joe@zerocapital.com>
joeshull
added a commit
that referenced
this pull request
Apr 8, 2026
…ough (#121) - README: remove _v1/_v2 suffixes from evaluation guide file references - Markdownlint: fix MD058/MD037/MD003 in 2 MATPOWER research files - Tests: update 36 stale test expectations across 6 test files to match current page structure (### headings vs <details> cards, Strong/Adequate/ Weak/Failing tiers vs letter grades, updated risk register count, current page content patterns) - Full test suite: 270 passed, 0 failed Co-authored-by: Joe <joe@zerocapital.com>
joeshull
added a commit
that referenced
this pull request
Apr 8, 2026
…ough (#121) - README: remove _v1/_v2 suffixes from evaluation guide file references - Markdownlint: fix MD058/MD037/MD003 in 2 MATPOWER research files - Tests: update 36 stale test expectations across 6 test files to match current page structure (### headings vs <details> cards, Strong/Adequate/ Weak/Failing tiers vs letter grades, updated risk register count, current page content patterns) - Full test suite: 270 passed, 0 failed Co-authored-by: Joe <joe@zerocapital.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_v1/_v2suffixes)Context
Fresh-clone analyst walkthrough revealed that report tests were written for an older page template (
<details>cards, letter-grade CSS classes likegrade-b-plus) but the pages were rewritten to use### Tool (Tier)headings with the Strong/Adequate/Weak/Failing tier system.Verification
npm run build✓make validate✓ (747 refs, 0 broken)Test plan
npm run buildsucceedsuv run python -m pytest tests/ -v— 270/270 passpre-commit run --all-files— markdownlint passes